-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WJ-1196] Add support for S3 presign URLs to upload blobs #1918
Draft
emmiegit
wants to merge
38
commits into
develop
Choose a base branch
from
WJ-1196-presign
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmiegit
force-pushed
the
WJ-1196-presign
branch
from
June 12, 2024 11:22
a39aed2
to
7d6aeb7
Compare
emmiegit
force-pushed
the
WJ-1196-presign
branch
2 times, most recently
from
July 11, 2024 04:42
e0d8218
to
1001d8d
Compare
emmiegit
force-pushed
the
WJ-1196-presign
branch
from
August 20, 2024 02:41
1001d8d
to
1df64c8
Compare
emmiegit
force-pushed
the
WJ-1196-presign
branch
2 times, most recently
from
September 8, 2024 22:38
3bced8d
to
b1a00ae
Compare
emmiegit
force-pushed
the
WJ-1196-presign
branch
2 times, most recently
from
September 18, 2024 04:08
2a8d252
to
4ba1c34
Compare
And complete FileService::finish_new_upload().
First need to figure out initial uploads, then will unify them in some nice, generic way.
emmiegit
force-pushed
the
WJ-1196-presign
branch
from
September 20, 2024 05:18
9ce6102
to
df1c682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.