some upgrades to vmallocator.h #6469
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goober5000
added
the
refactor
Goober5000
force-pushed
the
vmallocator_update
branch
3 times, most recently
from
ede068e to
98a2007
Compare
Make `SCP_vector`, `SCP_list`, `SCP_set`, and `SCP_multiset` subclasses of their STL counterparts. This allows helper functions to be added to each, including the `contains()` function which is not available until C++20. (This has minor effects on other parts of the codebase that treated `SCP_` and `std::` as synonyms.) Since there is now a nontrivial amount of code that needs to be in a .cpp file, create vmallocator.cpp. Note that `SCP_string` truncation has been refactored to use length rather than C-string size to be consistent with other `std::basic_string` functions. Also, remove some enum class hashing code which is no longer necessary now that the codebase is at C++17.
Goober5000
force-pushed
the
vmallocator_update
branch
from
98a2007 to
b5270fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
SCP_vector,SCP_list,SCP_set, andSCP_multisetsubclasses of their STL counterparts. This allows helper functions to be added to each, including thecontains()function which is not available until C++20. (This has minor effects on other parts of the codebase that treatedSCP_andstd::as synonyms.) Since there is now a nontrivial amount of code that needs to be in a .cpp file, create vmallocator.cpp.Note that
SCP_stringtruncation has been refactored to use length rather than C-string size to be consistent with otherstd::basic_stringfunctions.Also, remove some enum class hashing code which is no longer necessary now that the codebase is at C++17.