Upgrade to rails 7.2 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnestler
commented
Jan 10, 2025
|
|
||
| # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies. | ||
| config.force_ssl = false | ||
| config.force_ssl = true |
There was a problem hiding this comment.
This should really be true. For local testing we can change the RAILS_ENV variable in the docker-compose.yml file.
There was a problem hiding this comment.
Tested locally with the RAILS_ENV change in the docker-compose.yml file.
rnestler
force-pushed
the
upgrade-to-rails-7.2
branch
from
491e226 to
4d54c54
Compare
rnestler
commented
Jan 10, 2025
| # Enables YJIT as of Ruby 3.3, to bring sizeable performance improvements. If you are | ||
| # deploying to a memory constrained environment you may want to set this to `false`. | ||
| #++ | ||
| # Rails.application.config.yjit = true |
There was a problem hiding this comment.
This may be something that we need to disable if we run into memory issues.
rnestler
force-pushed
the
upgrade-to-rails-7.2
branch
from
4d54c54 to
7f6878b
Compare
rnestler
force-pushed
the
upgrade-to-rails-7.2
branch
from
f16595b to
8cffe7d
Compare
|
Sudden CI failure (also on main) seems to be because of docker-library/ruby@7f078b1. It already got reverted in docker-library/ruby@6f84caa, but we may need to wait for it to be released. Let's fix it now: #15 |
We do not yet have a DB and the migrations are only needed for active storage.
Since we don't use the db yet, it still worked with the wrong PW.
rnestler
force-pushed
the
upgrade-to-rails-7.2
branch
from
8cffe7d to
1022c69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket-22953