Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ux with clean navigation and better a11y #28

Closed
wants to merge 10 commits into from
Closed

Improve ux with clean navigation and better a11y #28

wants to merge 10 commits into from

Conversation

manuelmeister
Copy link
Contributor

@manuelmeister manuelmeister commented Apr 9, 2024

I tried to improve on the current design. I also improved the accessibility of the navigation and forms.

Feature Deployment: https://manuelmeister.github.io/hering/

Improved navigation on mac:

before after
Bildschirmfoto 2024-04-11 um 22 32 14 Bildschirmfoto 2024-04-11 um 22 33 14

Improved calendar: https://manuelmeister.github.io/hering/#/calendar

before after
Bildschirmfoto 2024-04-11 um 22 34 20 Bildschirmfoto 2024-04-11 um 22 34 07

@manuelmeister
Copy link
Contributor Author

@mario-zelger can you have a look? 😊

@mario-zelger
Copy link
Collaborator

Very nice, thank you! Will check it out tomorrow and most likely merge right away 👍

@mario-zelger mario-zelger self-requested a review April 12, 2024 07:32
@ewangler
Copy link
Member

@manuelmeister very very cool! thanks a lot! 🎉 i love the fish 🐟

there is just one small thing that i'm not 100% sure about: in the calendar you changed the link to the chapter to "Kapitel". i get that and it's better because it's shorter, but maybe it's also not that clear for a user. maybe there is an other label like "Zum Kapitel" or "Mehr Infos"...

@mario-zelger
Copy link
Collaborator

I manually merged the pull request on my side because I realized that I forgot to push one commit before the fall courses. Of course there were some conflicts 🤦‍♂️.

Unfortunately, GitHub does not seem to have recognized that merge here. Therefore, I would close this one without an explict merge via GH.

@manuelmeister Can you check out the current develop branch? All of your changes should be there.

@manuelmeister
Copy link
Contributor Author

manuelmeister commented Apr 16, 2024

Strange 🤨

@manuelmeister manuelmeister deleted the feature/improve-ux branch April 16, 2024 18:48
@manuelmeister
Copy link
Contributor Author

@mario-zelger don't forget to deploy

@mario-zelger
Copy link
Collaborator

mario-zelger commented Apr 16, 2024

all done 👍 thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants