-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ux with clean navigation and better a11y #28
Conversation
@mario-zelger can you have a look? 😊 |
Very nice, thank you! Will check it out tomorrow and most likely merge right away 👍 |
@manuelmeister very very cool! thanks a lot! 🎉 i love the fish 🐟 there is just one small thing that i'm not 100% sure about: in the calendar you changed the link to the chapter to "Kapitel". i get that and it's better because it's shorter, but maybe it's also not that clear for a user. maybe there is an other label like "Zum Kapitel" or "Mehr Infos"... |
I manually merged the pull request on my side because I realized that I forgot to push one commit before the fall courses. Of course there were some conflicts 🤦♂️. Unfortunately, GitHub does not seem to have recognized that merge here. Therefore, I would close this one without an explict merge via GH. @manuelmeister Can you check out the current develop branch? All of your changes should be there. |
Strange 🤨 |
@mario-zelger don't forget to deploy |
all done 👍 thank you very much! |
I tried to improve on the current design. I also improved the accessibility of the navigation and forms.
Feature Deployment: https://manuelmeister.github.io/hering/
Improved navigation on mac:
Improved calendar: https://manuelmeister.github.io/hering/#/calendar