Skip to content

Commit

Permalink
Add criteria for merging a PR
Browse files Browse the repository at this point in the history
This is something that comes up in conversation periodically and adding
it to this document increases transparency regarding the process of PR
review.
  • Loading branch information
jacobherrington authored Dec 1, 2018
1 parent c6c3b15 commit aff6800
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,14 @@ At this point you're waiting on us. We like to at least comment on, if not
accept, pull requests within three business days (and, typically, one business
day). We may suggest some changes or improvements or alternatives.

Typically, Pull Requests can be merged when they have met the following criteria:

- Open for at least 24 hours
- Passing CI
- 2 or more Core Team approvals

Though in some cases the Core Team may choose not to merge a PR that meets these requirements.

### Pull Request guidelines

* The specs must pass for each individual commit.
Expand Down

0 comments on commit aff6800

Please sign in to comment.