New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrapped setItem promise in angular promise #150

Closed

jeremyaurelius wants to merge 0 commits into scotttrinh:master from jeremyaurelius:master

jeremyaurelius commented Apr 5, 2019

Fixes issue
#149

Wraps setItem promise so that finally call can be used.

Owner

scotttrinh commented Apr 5, 2019

@jairemix

Thanks for the PR! A few quick asks:

Remove the version bumping and built code (I'll do that when I release a version)
Can we write a test for this by using .finally on some new test or an exisitng test? Whichever you find easier to add.

scotttrinh self-requested a review

April 5, 2019 18:55

jeremyaurelius closed this

jeremyaurelius force-pushed the master branch from bb7cb66 to 00b3116 Compare

April 20, 2019 11:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet