Skip to content

Commit

Permalink
switch to pnpm
Browse files Browse the repository at this point in the history
  • Loading branch information
michioxd authored and scottlamb committed Apr 14, 2024
1 parent 8036aa4 commit 9ede361
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,10 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 18
- run: cd ui && npm ci
- run: cd ui && npm run build
- run: cd ui && npm run test
- run: npm i -g pnpm
- run: cd ui && pnpm i --frozen-lockfile
- run: cd ui && pnpm run build
- run: cd ui && pnpm run test
# Upload the UI and changelog as *job* artifacts (not *release* artifacts), used below.
- uses: actions/upload-artifact@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion guide/build.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ $ cd ..
$ sudo rsync --recursive --delete --chmod=D755,F644 ui/dist/ /usr/local/lib/moonfire-nvr/ui
```

You can use `npm` instead if you don't want to use `pnpm`.
For more information about using `pnpm`, check out the [Developing UI Guide](./developing-ui.md#requirements).

If you wish to bundle the UI into the binary, you can build the UI first and then pass
`--features=bundled-ui` when building the server. See also the
Expand Down
5 changes: 3 additions & 2 deletions guide/developing-ui.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ this in the webpack documentation.
## Requirements

* Node.js v18+
* `npm` or `pnpm` installed
* `pnpm` installed

This guide below will use [`pnpm`](https://pnpm.io/) as package manager instead `npm`. But you can still use `npm`. We highly recommended you to switch to `pnpm`.
This guide below will use [`pnpm`](https://pnpm.io/) as package manager instead
`npm`. So we highly recommended you to use `pnpm` in this project.

## Getting started

Expand Down

0 comments on commit 9ede361

Please sign in to comment.