-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatible with autocomplete source function #21
base: master
Are you sure you want to change the base?
Conversation
Call accentFolding.fold at $.ui.autocomplete.filter() and leaving autocomplete.source as original. Works with the three types of source: array of values, function or url-string. Tested with "multiple" jquery-ui autocomplete example. https://jqueryui.com/autocomplete/#multiple
What are you trying to accomplish with this change? |
With this change the extension does the same than before but extends the usage to source function calls. I want a multiple selection box as seen in autocomplete example [https://jqueryui.com/autocomplete/#multiple] The autocomplete source must be defined at initialization as a function but the current accentFolding extension does not work because of the isArray check. Of course I can mix the multiple example with folding example in a new source function and ignoring the extension, but doing this he source function definition becomes a matter for every autocomplete instance. |
|
Oh, I see, because the remote example is using the filter directly. |
Can you clean up the code to actually follow the existing style and indentation? |
Style and identation
Done. Forgot to answer. |
Call accentFolding.fold at $.ui.autocomplete.filter() and leaving autocomplete.source as original.
Works with the three types of source: array of values, function or url-string.
Tested with "multiple" jquery-ui autocomplete example. https://jqueryui.com/autocomplete/#multiple