Skip to content

Commit

Permalink
add changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
scottaohara committed Jun 28, 2018
1 parent 77c02a7 commit 7d4c7b9
Show file tree
Hide file tree
Showing 3 changed files with 61 additions and 6 deletions.
57 changes: 57 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
# Changelog
All notable changes to this project will be documented in this file.

## [Unreleased]
Optional feature to add support for up/down arrow keys

## [3.2.0] - 2018-06-28
### Added
- package.json and registered as NPM package.

### Changed
- `data-transition` attribute no longer allows for a value. Instead it merely adds a transition class to each accordion panel to allow for transitions for specific CSS properties to be customized in the CSS file.
- Instead of requiring `.js` prior to CSS selectors, remove this `.js` selector dependency and have the base markup utilize data attributes. When the script runs on page load, the classes that were there by default will now be applied by the script.

## [3.1.1] - 2018-06-11
### Added
- Add "arrows" for accordion trigger styling.


## [3.1.0] - 2018-02-09
### Changed
- [Modify the manner in which IDs are generated](https://github.com/scottaohara/a11y_accordions/commit/5723fafddac2dcbf102a0f99bd9f6d3b2e676dd1).


## [3.0.0] - 2018-02-09
### Added
- CSS to ensure list semantics are respected with Safari + VoiceOver.

### Changed
- Updated documentation and notes about screen reader usability.
- Allow accordions to have an `ol` or `ul` base markup pattern.
- Fix bug with multi-accordion panels.


## [2.0.1] - 2017-10-27
### Changed
- NaN bug fix.


## [2.0.0] - 2017-10-24
### Changed
- Converted script from jQuery to ES5 Vanilla JavaScript.

### Removed
- jQuery dependency
- CSS :target selector for no-js functionality. Instead the no-js functionality should just be the static underlying markup.


## 1.0.2 - 2017-10-24
### Added
- CSS :target selector for no-js functionality

### Changed
- Fix spacebar bug with Firefox
- Modified styling selectors
- Smarter selectors for nesting of accordion widgets
- Timeout function to mitigate Firefox animation issue
3 changes: 1 addition & 2 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,7 @@ <h2 class="demo-heading">
Constantly opened panel &amp; nested accordion example
</h2>

<div data-aria-accordion
data-constant>
<div data-aria-accordion data-constant>
<h3 data-aria-accordion-heading>
Chapter 4
</h3>
Expand Down
7 changes: 3 additions & 4 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@
idCounter += 1;

for ( i = 0; i < widget.length; i++ ) {
var t;
self = widget[i];
var t;

/**
* Check for IDs and create arrays of necessary
Expand All @@ -61,9 +61,8 @@
/**
* Setup accordion classes
*/
if ( !self.classList.contains(widgetClass) ) {
self.classList.add(widgetClass);
}
self.classList.add(widgetClass);


/**
* Get all panels & headings of an accordion pattern based
Expand Down

0 comments on commit 7d4c7b9

Please sign in to comment.