Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog grid component #445

Closed
wants to merge 2 commits into from

Conversation

Sapnajha19
Copy link

Description

Created a BlogGrid component for the fifth theme with responsive design.

Related Issue

#416

Screenshots (In case of UI changes):

Desktop
localhost_8000 - Google Chrome 18-03-2023 13_58_37

Mobile
mobile

Tablet
mobile (1)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests have passed and it does not give any unexpected error for the same.

@dhruv18ranjan
Copy link

dhruv18ranjan commented Mar 18, 2023

Hey .. Actually I already did that !

@Sapnajha19
Copy link
Author

Hey .. Actually I already did that !

Oh I see, Actually I saw the issue opened that's why I created the pull request. Sorry for the confusion.

@dhruv18ranjan
Copy link

Oh I see, Actually I saw the issue opened that's why I created the pull request. Sorry for the confusion.

No problem

@Sapnajha19
Copy link
Author

Oh I see, Actually I saw the issue opened that's why I created the pull request. Sorry for the confusion.

No problem

Hey, so should I close this pull request then? Actually, I made this to understand the codebase and git workflow. But there are some problems with this pr so I am thinking of creating a new pull request for the same issue. Are you okay with me creating a new one or should I close this one and not create a new pr for the same issue?

@dhruv18ranjan
Copy link

Yeah I see now there is some issue in this PR . I think you should create a new pr for another issue as 2 pr for the same issue can create conflicts .

@Sapnajha19
Copy link
Author

Okay, Thank you

@Sapnajha19 Sapnajha19 closed this Mar 19, 2023
@Sapnajha19 Sapnajha19 deleted the blog-grid-component branch March 21, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants