Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove default replicas=1 value from workload conversion #27

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

astromechza
Copy link
Member

This was mentioned in #25 as causing issues with deployments that have an HPA or have been scaled up by hand already. I'm not entirely sure why we had this default, possibly due to a previous proof of concept or example. Not breaking change since 1 is the default replicas.

Thanks @maxstepanov for bringing this to our attention!

@mathieu-benoit
Copy link
Contributor

While it's done for Deployment, should it be done for StatefulSet too? https://github.com/score-spec/score-k8s/blob/main/internal/convert/workloads.go#L258

Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astromechza astromechza merged commit 26e2211 into main Sep 3, 2024
5 checks passed
@astromechza astromechza deleted the remove-default-repliaces branch September 3, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants