chore: move all implementation code to internal (#16)

Move all implementation code to /internal so that tools like gorelease
don't consider it part of the public API. Also removes /cmd as it is no
longer supported. usql works better as CLI.

Testing Done: go test ./internal/isql/...

Makefile

@@ -1,8 +1,8 @@
 .PHONY: thrift
 thrift:
-	thrift -r -gen go:package_prefix=github.com/sclgo/impala-go/services/ interfaces/ImpalaService.thrift
-	rm -rf ./services
-	mv gen-go services
+	thrift -r -gen go:package_prefix=github.com/sclgo/impala-go/internal/services/ interfaces/ImpalaService.thrift
+	rm -rf ./internal/services
+	mv gen-go ./internal/services
 
 .PHONY: cli
 cli: usql

driver.go

@@ -16,13 +16,14 @@ import (
 
 	"github.com/apache/thrift/lib/go/thrift"
 	"github.com/samber/lo"
-	"github.com/sclgo/impala-go/hive"
-	"github.com/sclgo/impala-go/sasl"
+	"github.com/sclgo/impala-go/internal/hive"
+	"github.com/sclgo/impala-go/internal/isql"
+	"github.com/sclgo/impala-go/internal/sasl"
 )
 
 var (
 	// ErrNotSupported means this operation is not supported by impala driver
-	ErrNotSupported = errors.New("impala: not supported")
+	ErrNotSupported = isql.ErrNotSupported
 )
 
 // Driver to impala
@@ -170,7 +171,7 @@ func (c *connector) Driver() driver.Driver {
 	return c.d
 }
 
-func connect(opts *Options) (*Conn, error) {
+func connect(opts *Options) (*isql.Conn, error) {
 
 	addr := net.JoinHostPort(opts.Host, opts.Port)
 
@@ -242,5 +243,5 @@ func connect(opts *Options) (*Conn, error) {
 		QueryTimeout: opts.QueryTimeout,
 	})
 
-	return &Conn{client: client, t: transport, log: logger}, nil
+	return isql.NewConn(client, transport, logger), nil
 }

examples/enumerateDB.go

@@ -28,7 +28,9 @@ func main() {
 
 	connector := impala.NewConnector(&opts)
 	db := sql.OpenDB(connector)
-	defer db.Close()
+	defer func() {
+		_ = db.Close()
+	}()
 
 	ctx := context.Background()
 

hive/client.go → internal/hive/client.go

@@ -6,7 +6,7 @@ import (
 	"strconv"
 
 	"github.com/apache/thrift/lib/go/thrift"
-	"github.com/sclgo/impala-go/services/cli_service"
+	"github.com/sclgo/impala-go/internal/services/cli_service"
 )
 
 // Client represents Hive Client

hive/dbmetadata.go → internal/hive/dbmetadata.go

@@ -10,8 +10,7 @@ import (
 	"time"
 
 	"github.com/samber/lo"
-
-	"github.com/sclgo/impala-go/services/cli_service"
+	"github.com/sclgo/impala-go/internal/services/cli_service"
 )
 
 type TableName struct {

hive/dbmetadata_test.go → internal/hive/dbmetadata_test.go

@@ -7,7 +7,7 @@ import (
 	"testing"
 
 	"github.com/google/uuid"
-	"github.com/sclgo/impala-go/services/cli_service"
+	"github.com/sclgo/impala-go/internal/services/cli_service"
 	"github.com/stretchr/testify/require"
 )
 

hive/hive.go → internal/hive/hive.go

@@ -4,7 +4,7 @@ import (
 	"errors"
 	"fmt"
 
-	"github.com/sclgo/impala-go/services/cli_service"
+	"github.com/sclgo/impala-go/internal/services/cli_service"
 )
 
 const (

hive/metadata.go → internal/hive/metadata.go

@@ -5,7 +5,7 @@ import (
 	"reflect"
 	"time"
 
-	"github.com/sclgo/impala-go/services/cli_service"
+	"github.com/sclgo/impala-go/internal/services/cli_service"
 )
 
 type TableSchema struct {

hive/operation.go → internal/hive/operation.go

@@ -6,7 +6,7 @@ import (
 	"time"
 
 	"github.com/samber/lo"
-	"github.com/sclgo/impala-go/services/cli_service"
+	"github.com/sclgo/impala-go/internal/services/cli_service"
 )
 
 const (

hive/operation_test.go → internal/hive/operation_test.go

@@ -5,9 +5,8 @@ import (
 	"log"
 	"testing"
 
+	"github.com/sclgo/impala-go/internal/services/cli_service"
 	"github.com/stretchr/testify/require"
-
-	"github.com/sclgo/impala-go/services/cli_service"
 )
 
 func TestOperation(t *testing.T) {

hive/result_set.go → internal/hive/result_set.go

@@ -5,7 +5,7 @@ import (
 	"io"
 	"time"
 
-	"github.com/sclgo/impala-go/services/cli_service"
+	"github.com/sclgo/impala-go/internal/services/cli_service"
 )
 
 // ResultSet ...

hive/result_set_test.go → internal/hive/result_set_test.go

@@ -7,9 +7,8 @@ import (
 	"testing"
 
 	"github.com/samber/lo"
+	"github.com/sclgo/impala-go/internal/services/cli_service"
 	"github.com/stretchr/testify/require"
-
-	"github.com/sclgo/impala-go/services/cli_service"
 )
 
 func TestResultSet(t *testing.T) {

hive/session.go → internal/hive/session.go

@@ -3,7 +3,7 @@ package hive
 import (
 	"context"
 
-	"github.com/sclgo/impala-go/services/cli_service"
+	"github.com/sclgo/impala-go/internal/services/cli_service"
 )
 
 // Session represents hive session

connection.go → internal/isql/connection.go

@@ -1,14 +1,20 @@
-package impala
+package isql
 
 import (
 	"context"
 	"database/sql/driver"
+	"errors"
 	"fmt"
 	"log"
 	"time"
 
 	"github.com/apache/thrift/lib/go/thrift"
-	"github.com/sclgo/impala-go/hive"
+	"github.com/sclgo/impala-go/internal/hive"
+)
+
+var (
+	// ErrNotSupported means this operation is not supported by impala driver
+	ErrNotSupported = errors.New("impala: not supported")
 )
 
 // Conn to impala. It is not used concurrently by multiple goroutines.
@@ -136,3 +142,11 @@ func (c *Conn) Close() error {
 	}
 	return nil
 }
+
+func NewConn(client *hive.Client, transport thrift.TTransport, logger *log.Logger) *Conn {
+	return &Conn{
+		t:      transport,
+		client: client,
+		log:    logger,
+	}
+}