Update splitter.py #412
Closed
Update splitter.py #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support for new entries on the same line
|
Thanks for the PR. Besides the fact that there are still failing tests, this PR won't be mergeable in its current form: The "every block starts on a new line" is encoded in a variety of places, and extra care as well as significant testing will have to be added when changing this behavior. I have myself played around a bit with changing this, but am unfortunately quite limited in time at the moment. Thus, opening my own PR for this will not happen very soon. Thus, @benlogan, if you intend to continue working on this PR, go ahead. Just drop a message here to make sure we're not both working on this at the same time. |
|
(closed by accident - immediately reopened) |
2 tasks
|
Replaced by #416 |
MiWeiss
pushed a commit
that referenced
this pull request
Nov 4, 2023
closes #411 This PR replaced an in-part identical PR #412 by @benlogan. He is thus added as co-author. Co-authored-by: Ben Logan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for new entries on the same line
has been tested locally with files that were previously triggering the bug mentioned in
#411
but hasn't been unit tested
I'm still just getting my head around how this library works - so it's worth checking carefully.
but I think this is an important change - I spent hours trying to work out what was causing corruption in my exported files