Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option IS_LIBSNARK_PARENT #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

riemann89
Copy link

If we import libsnark as submodule dependency in a project that has his own CMakeLists.txt file, we are not able to define make check or make doc since they are defined yet by libsnark.

More specifically we have these problems:

  • cmake .. does not compile because check, doc target collides with check, doc target defined into libsnark.
  • make test has view of all the test defined libsnark/CMakeLists.txt and will try to execute them.

For these reasons, adding IS_LIBSNARK_PARENT option facilitates the inclusion of libsnark as submodule dependency into a repository without requesting modifications. In the main repository will be enough to define OPTION(IS_LIBFF_PARENT OFF).

This is the same approach used in libsnark dependencies https://github.com/scipr-lab/libsnark/blob/master/depends/CMakeLists.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant