Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we import libsnark as submodule dependency in a project that has his own
CMakeLists.txt
file, we are not able to definemake check
ormake doc
since they are defined yet by libsnark.More specifically we have these problems:
cmake ..
does not compile becausecheck
,doc
target collides withcheck
,doc
target defined into libsnark.make test
has view of all the test definedlibsnark/CMakeLists.txt
and will try to execute them.For these reasons, adding
IS_LIBSNARK_PARENT
option facilitates the inclusion of libsnark as submodule dependency into a repository without requesting modifications. In the main repository will be enough to defineOPTION(IS_LIBFF_PARENT OFF)
.This is the same approach used in libsnark dependencies https://github.com/scipr-lab/libsnark/blob/master/depends/CMakeLists.txt