-
Notifications
You must be signed in to change notification settings - Fork 1
Supermirror, flipper matrices, and workflow with configurable polarizer/analyzer #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's hard to review this without a description of the procedure. I did not find anything out flippers in the polarization analysis methodology page. What source did you use to implement this @SimonHeybrock? |
@astellhorn was adding information in #56, but I think a file was missing and the PR needs updating. Otherwise, have a look at the attachments in #2 (comment) (probably not most recent version). |
Yes, I forgot to add the new methodology file into the branch, and will update it (best today, but I am on a conference since sunday up to tomorrow, but will have some time today lunch break). |
now it is under esspolarization/docs /user-guide/ --> see file General-sans-polarization-analysis-methodology.ipynb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me! I just have one question about the flipper implementation.
f = 1 / self.efficiency.value | ||
if f == 1: | ||
return up, down | ||
return up, (1 - f) * up + f * down |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little bit confused about what's going on here.
What is the flipper matrix? Is it correct that when swap=False
then the flipper matrix is
with inverse
Does from_left
compute
In this case that seems to be the same as in the code.
Does from_right
compute
In this case the code is different from what I expected, what's wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we dot have a vector [u, d]
but a matrix [[u, d], [d, u]]
. The function returns one of the resulting columns. Does it work out then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes then it works out 👍
This adds:
PolarizationAnalysisWorkflow
, which composes workflows for the polarization and analyzer (each can be He3 or supermirror) into a single workflow.Fixes #59.