Fix max matrix size in SCIPexprComputeQuadraticCurvature #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose we can change it. But computing the eigenvalues+vectors for matrices of such large dimension with a dense code won't be particular fast. Using some sparse routines would be better here, but we don't have this available at the moment. |
|
Applied this change to master via c952b3a. |
MaximSmolskiy
deleted the
fix-max-matrix-size-in-SCIPexprComputeQuadraticCurvature
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem that in comment and in calculation number
214748364was used asINT_MAX, butINT_MAXis equal to2^31 - 1 = 2147483647, so last digit was missed