Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to resume workflow when codecov push fails #909

Merged
merged 12 commits into from
Feb 20, 2024

Conversation

AlexVCaron
Copy link
Contributor

Quick description

Codecov is not super stable right now. When the coverage upload fails, we need to re-run the whole test suite (long). This PR splits the workflow in twain, so only the second job fails when codecov push fails. Then, to retry the upload, re-run the workflow, specifying to run ONLY the failed jobs. Voilà ?

Type of change

Check the relevant options.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@AlexVCaron AlexVCaron changed the title Ability to resume workflow when codecov push fails [WIP] Ability to resume workflow when codecov push fails Feb 19, 2024
@AlexVCaron AlexVCaron added Wait updates WIP Work In Progress labels Feb 19, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c4b850) 65.92% compared to head (747da90) 68.12%.
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
+ Coverage   65.92%   68.12%   +2.20%     
==========================================
  Files         386      386              
  Lines       21573    20678     -895     
  Branches     3540     3160     -380     
==========================================
- Hits        14222    14087     -135     
+ Misses       5720     5326     -394     
+ Partials     1631     1265     -366     
Components Coverage Δ
Scripts 70.68% <ø> (+3.40%) ⬆️
Library 63.76% <ø> (+0.29%) ⬆️

@AlexVCaron AlexVCaron changed the title [WIP] Ability to resume workflow when codecov push fails Ability to resume workflow when codecov push fails Feb 20, 2024
@AlexVCaron AlexVCaron removed the WIP Work In Progress label Feb 20, 2024
@arnaudbore arnaudbore merged commit 9412961 into scilus:master Feb 20, 2024
2 checks passed
@AlexVCaron AlexVCaron deleted the fix/separate_codecov_job branch February 20, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants