Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage sources #902

Merged
merged 7 commits into from
Feb 16, 2024
Merged

Conversation

AlexVCaron
Copy link
Contributor

@AlexVCaron AlexVCaron commented Feb 15, 2024

Quick description

Codecov.io is not finding the changes associated to the uploaded coverage metrics. This PR will address this, but it is done through iterative fixing.

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)

Provide data, screenshots, command line to test (if relevant)

codecov.io will tell everything

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9565115) 65.95% compared to head (6ae0976) 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #902       +/-   ##
==========================================
- Coverage   65.95%   0.00%   -65.96%     
==========================================
  Files         384     384               
  Lines       21352   21352               
  Branches     3495    3495               
==========================================
- Hits        14083       0    -14083     
- Misses       5661   21352    +15691     
+ Partials     1608       0     -1608     
Components Coverage Δ
Scripts 0.00% <ø> (∅)
Library 0.00% <ø> (∅)

@AlexVCaron AlexVCaron changed the title [WIP] Fix coverage sources Fix coverage sources Feb 16, 2024
@AlexVCaron
Copy link
Contributor Author

Merge when you want. PR will still have 0 coverage, but merge to master should be correct.

@arnaudbore arnaudbore merged commit 89ca33f into scilus:master Feb 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants