Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify b0 threshold #867

Merged
merged 26 commits into from
Feb 29, 2024
Merged

Clarify b0 threshold #867

merged 26 commits into from
Feb 29, 2024

Commits on Feb 29, 2024

  1. Rename --force_b0_threshold. Add official --b0_threshold option.

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    31cc82b View commit details
    Browse the repository at this point in the history

  2. scil_dwi_detect_volume_outliers: use official arg.

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    af4974a View commit details
    Browse the repository at this point in the history

  3. scil_dti_metrics: use b0_threshold. Usage in dipy to be verified.

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    9911552 View commit details
    Browse the repository at this point in the history

  4. scil_dwi_extract_b0: already ok. Use official b0_threshold.

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    c3c3b63 View commit details
    Browse the repository at this point in the history

  5. scil_dwi_to_sh: using official arg. + [FIX] force_b0 was not used! Da… 

    …ta was loaded twice. Fixed
    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    98cd50f View commit details
    Browse the repository at this point in the history

  6. scil_fodf_msmt: Only using tolerance. Link to dipy issue added.

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    4c105fd View commit details
    Browse the repository at this point in the history

  7. scil_fodf_ssst: [FIX] Was always using minimal b-value as threshold. … 

    …Adding b0_treshold arg.
    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    5cb2dd9 View commit details
    Browse the repository at this point in the history

  8. scil_sh_to_sf: No b0_threshold option existed. Added.

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    999b757 View commit details
    Browse the repository at this point in the history

  9. scil_qball_metrics: Only the minimal b-value was used. Adding b0_thre… 

    …shold.
    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    e009e2f View commit details
    Browse the repository at this point in the history

  10. scil_dki_metrics: could not modify the identify_shells method right n… 

    …ow. Only using tolerance.
    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    98e6517 View commit details
    Browse the repository at this point in the history

  11. scil_frf_ssst: Add the b0_threshold option.

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    4ea5d1c View commit details
    Browse the repository at this point in the history

  12. scil_frf_msmt: Cannot modify for now. Adding explanation, using toler… 

    …ance.
    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    3060a84 View commit details
    Browse the repository at this point in the history

  13. scil_frf_memsmt: Can't change. Added explanations.

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    316febd View commit details
    Browse the repository at this point in the history

  14. scil_fodf_memsmt: Idem

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    0cca6f6 View commit details
    Browse the repository at this point in the history

  15. scil_btensor_metrics: Idem. Removing unused option force_b0.

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    fd09544 View commit details
    Browse the repository at this point in the history

  16. Fix pep8

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    aceacb0 View commit details
    Browse the repository at this point in the history

  17. Answer some comments

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    778ddd9 View commit details
    Browse the repository at this point in the history

  18. Do no use 'args' in check_b0

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    41c2533 View commit details
    Browse the repository at this point in the history

  19. Answering a few more comments

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    949670c View commit details
    Browse the repository at this point in the history

  20. Answer Phil: same explanation for tolerance everywhere

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    85e0d7f View commit details
    Browse the repository at this point in the history

  21. pep8

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    a1c1b23 View commit details
    Browse the repository at this point in the history

  22. Added tests wrong b0

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    d9f5e45 View commit details
    Browse the repository at this point in the history

  23. sh_to_sf: Fixes + Test more exhaustively

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    4981bce View commit details
    Browse the repository at this point in the history

  24. scil_sh_to_sf: FIX part2. Presence of b0s in the bvals actually not e… 

    …xpected
    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    56ea1d6 View commit details
    Browse the repository at this point in the history

  25. Fix pep8

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    b1ae3e2 View commit details
    Browse the repository at this point in the history

  26. Add unit test

    @EmmaRenauld
    EmmaRenauld committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    3ce0db0 View commit details
    Browse the repository at this point in the history