Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting scripts for new assert_inputs_exist function #1139

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

karanphil
Copy link
Contributor

Quick description

Here is a small PR adjusting two scripts for the new assert_inputs_exist function. I did not find other scripts where the new feature could simplify the code. Closes #1116

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (eb2e9ba) to head (5651a22).
Report is 2 commits behind head on master.

❌ Your project status has failed because the head coverage (69.97%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1139   +/-   ##
=======================================
  Coverage   69.96%   69.97%           
=======================================
  Files         448      448           
  Lines       24291    24289    -2     
  Branches     3334     3334           
=======================================
+ Hits        16996    16997    +1     
+ Misses       5874     5872    -2     
+ Partials     1421     1420    -1     
Components Coverage Δ
Scripts 70.73% <100.00%> (-0.01%) ⬇️
Library 68.97% <ø> (+0.02%) ⬆️

@arnaudbore arnaudbore added this pull request to the merge queue Feb 6, 2025
Merged via the queue into scilus:master with commit 8778f77 Feb 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust script for new assert_inputs_exist feature (list of lists of paths)
2 participants