Add Sciply version - part 3 #1135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1135 +/- ##
==========================================
+ Coverage 69.96% 70.04% +0.07%
==========================================
Files 448 448
Lines 24291 24363 +72
Branches 3334 3334
==========================================
+ Hits 16996 17065 +69
- Misses 5874 5878 +4
+ Partials 1421 1420 -1
|
karanphil
reviewed
Feb 4, 2025
| @@ -19,6 +19,8 @@ | |||
| from scilpy.io.utils import (assert_inputs_exist, | |||
| add_verbose_arg, | |||
| parser_color_type) | |||
|
|
|||
| @@ -52,6 +52,8 @@ | |||
| CuttingStyle | |||
| from scilpy.tractograms.streamline_operations import \ | |||
| resample_streamlines_step_size | |||
| from scilpy.version import version_string | |||
|
|
|||
| @@ -102,14 +102,17 @@ | |||
| read_info_from_mb_bdo, assert_headers_compatible) | |||
| from scilpy.segment.streamlines import (filter_cuboid, filter_ellipsoid, | |||
| filter_grid_roi) | |||
| from scilpy.version import version_string | |||
|
|
|||
| @@ -35,6 +35,7 @@ | |||
| from scilpy.io.utils import (assert_inputs_exist, | |||
| add_verbose_arg, | |||
| parser_color_type) | |||
| from scilpy.version import version_string | |||
| from scilpy.viz.color import generate_local_coloring | |||
|
|
|||
| @@ -23,15 +23,17 @@ | |||
| from scilpy.viz.gradients import (build_ms_from_shell_idx, | |||
| plot_each_shell, | |||
| plot_proj_shell) | |||
| from scilpy.version import version_string | |||
|
|
|||
| @@ -19,6 +19,8 @@ | |||
| from scilpy.io.utils import (assert_inputs_exist, | |||
| add_verbose_arg, | |||
| parser_color_type) | |||
|
|
|||
| from scilpy.version import version_string | |||
| from scilpy.viz.color import lut_from_matplotlib_name | |||
|
|
|||
| @@ -28,16 +28,18 @@ | |||
| add_verbose_arg, | |||
| assert_outputs_exist) | |||
| from scilpy.utils import is_float | |||
| from scilpy.version import version_string | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick description
Fix issue #760
Part 3 (final) of adding the Scilpy version to the scripts.
I also added a blank line in _build_arg_parser because some scripts (from scil_NODDI_maps.py to scil-volume_stats_in_ROI.py) had it and some others didn't: