Do not ignore legacy #1134
Merged
Do not ignore legacy #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (72.89%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1134 +/- ##
==========================================
+ Coverage 69.96% 72.89% +2.92%
==========================================
Files 448 448
Lines 24291 24289 -2
Branches 3334 3334
==========================================
+ Hits 16996 17705 +709
+ Misses 5874 5163 -711
Partials 1421 1421
|
EmmaRenauld
force-pushed
the
test_legacy
branch
from
138c5ce to
17ffe52
Compare
arnaudbore
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legagcy flies currently ignored from pytest (generated too many warnings, Arnaud got tired).
Adding back to supervise any error.
Legacy scripts will be deleted in a few versions, but meanwhile, checking that they work.