WIP "Fake" ambiant occlusion for MI-Brain

[frheault]

Quick description

This new option allows for the alteration of the saturation of streamlines based on the local density. It gives a better 3D feel to uniform coloring (and any other coloring). There is a parameter allowing to control how much effect it has, overall this is for specific needs in nice figure generation.

...

Type of change

Check the relevant options.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

• My code follows the style guidelines of this project (run autopep8)
• I added relevant citations to scripts, modules and functions docstrings and descriptions
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I moved all functions from the script file (except the argparser and main) to scilpy modules
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[pep8speaks]

Hello @frheault, Thank you for updating !

• In the file scilpy/viz/color.py:

Line 289:24: W291 trailing whitespace
Line 299:1: W293 blank line contains whitespace
Line 327:1: E302 expected 2 blank lines, found 1

• In the file scripts/scil_tractogram_assign_custom_color.py:

Line 140:80: E501 line too long (80 > 79 characters)
Line 229:80: E501 line too long (80 > 79 characters)

Comment last updated at 2024-09-30 19:07:43 UTC

[codecov]

Codecov Report

Attention: Patch coverage is 35.71429% with 36 lines in your changes missing coverage. Please review.

Project coverage is 68.69%. Comparing base (1d6f848) to head (0e3dd90).
Report is 16 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1030      +/-   ##
==========================================
- Coverage   68.78%   68.69%   -0.09%     
==========================================
  Files         429      429              
  Lines       22265    22305      +40     
  Branches     3324     3329       +5     
==========================================
+ Hits        15314    15322       +8     
- Misses       5665     5691      +26     
- Partials     1286     1292       +6     

Components	Coverage Δ
Scripts	69.60% <50.00%> (-0.05%)	⬇️
Library	67.40% <23.33%> (-0.14%)	⬇️

[arnaudbore]

LGTM