Tractograms: more unit tests #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @EmmaRenauld, Thank you for updating ! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-09-17 16:20:19 UTC |
EmmaRenauld
force-pushed
the
tractograms_more_unit_tests
branch
from
43e513b
to
a1a2284
Compare
EmmaRenauld
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1027 +/- ##
==========================================
+ Coverage 68.73% 68.78% +0.04%
==========================================
Files 429 429
Lines 22262 22265 +3
Branches 3322 3324 +2
==========================================
+ Hits 15301 15314 +13
+ Misses 5674 5665 -9
+ Partials 1287 1286 -1
|
arnaudbore
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few more unit tests + moved small util method in a more appropriate file.
dps_dps_management: 76% --> 93%
lazy_tractogram_operations: 0% --> 69%
streamline_operations: 46% --> 78%
This led to a FIX in streamlines_operations.cut_invalid_streamlines: one too many point was cut in invalid streamlines.