Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add mrds scripts part 2 #1022

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

arnaudbore
Copy link
Contributor

@arnaudbore arnaudbore commented Aug 7, 2024

Quick description

Script to compute FA, AD, MD, RD for each tensor found for MRDS
...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

Same as #1021

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@arnaudbore arnaudbore requested a review from mdesco August 7, 2024 22:47
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 41.81818% with 32 lines in your changes missing coverage. Please review.

Project coverage is 68.91%. Comparing base (2d8520c) to head (0c21c24).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
- Coverage   69.00%   68.91%   -0.10%     
==========================================
  Files         427      428       +1     
  Lines       22094    22158      +64     
  Branches     3297     3306       +9     
==========================================
+ Hits        15246    15270      +24     
- Misses       5563     5602      +39     
- Partials     1285     1286       +1     
Components Coverage Δ
Scripts 69.90% <41.81%> (-0.12%) ⬇️
Library 67.49% <ø> (-0.07%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant