Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module] Add bundle coloring #213

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

gagnonanthony
Copy link
Contributor

Describe your changes

Added the bundle/coloring module.

List test packages used by your module

  • bundles.zip

Checklist before requesting a review

  • Create the tool:
    • Edit ./modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./modules/nf-scil/<category>/<tool>/meta.yml
  • Generate the tests:
    • Edit ./tests/modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./tests/modules/nf-scil/<category>/<tool>/nextflow.config
    • Add test data locally for tests with the fork repository
    • Generate the test infrastructure and md5sum for all outputs
  • Ensure the syntax is correct :
    • Check indentation abides with the rest of the library (don't hesitate to correct others !)
    • Lint everything. Ensure your variables have good names.

@gagnonanthony gagnonanthony added the assembly New module or subworflow for nf-scil label Sep 10, 2024
@gagnonanthony gagnonanthony self-assigned this Sep 10, 2024
@gagnonanthony gagnonanthony linked an issue Sep 10, 2024 that may be closed by this pull request
@gagnonanthony gagnonanthony changed the title [Modules] Add bundle coloring [Module] Add bundle coloring Sep 10, 2024
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

Copy link
Contributor

@ThoumyreStanislas ThoumyreStanislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudbore arnaudbore added this pull request to the merge queue Sep 12, 2024
Merged via the queue into scilus:main with commit ae6935a Sep 12, 2024
10 checks passed
@gagnonanthony gagnonanthony deleted the colorbundle branch September 13, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assembly New module or subworflow for nf-scil
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundles coloring
3 participants