Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROV] Allow workflows to run on forks, except for test targets #197

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

AlexVCaron
Copy link
Collaborator

Type of improvement

If submitting a new module or fixing a bug, please use the appropriate template.

  • Documentation
  • Development tools (e.g. linter, formatter, etc.)
  • Development container
  • Global update (please specify)
  • Other (please specify)

Describe your improvement

Remove the restrictions on update_pr and update_main workflows to allow them to run on other repos than scilus/nf-scil. Still, block execution of the test sub-workflow so self-hosted runners aren't used.

Describe how to test your improvement

  1. Create a fork
  2. Rebase your fork's branch on this PR
  3. Push online and open a PR ON YOUR FORK
  4. Check that the workflow triggers and that the tests are skipped

Checklist before requesting a review

  • Ensure the syntax is correct (EditorConfig and Prettier must pass)
  • Run the test suites if your changes affect any module
  • Regenerate the Poetry lock file if you have updated the dependencies
  • Ensure the documentation is up-to-date

@AlexVCaron AlexVCaron added this pull request to the merge queue Sep 3, 2024
Merged via the queue into scilus:main with commit c42e548 Sep 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant