Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Add lesions option in bundle/stats module #183

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

ThoumyreStanislas
Copy link
Contributor

Describe your changes

Add option lesions in bundle/stats. Compute lesions stats as volume, streamlines counts.

List test packages used by your module

  • tractometry.zip

Checklist before requesting a review

  • Create the tool:
    • Edit ./modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./modules/nf-scil/<category>/<tool>/meta.yml
  • Generate the tests:
    • Edit ./tests/modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./tests/modules/nf-scil/<category>/<tool>/nextflow.config
    • Add test data locally for tests with the fork repository
    • Generate the test infrastructure and md5sum for all outputs
  • Ensure the syntax is correct :
    • Check indentation abides with the rest of the library (don't hesitate to correct others !)
    • Lint everything. Ensure your variables have good names.

Copy link
Contributor

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's almost perfect, only one alignment comment, and I saw in the snapshots that the outputted bundle label_maps have the .trk stuck somewhere in the name. I can investigate to find where it happens, but I think you'll find it quicker 😁

modules/nf-scil/bundle/stats/main.nf Outdated Show resolved Hide resolved
modules/nf-scil/bundle/stats/main.nf Outdated Show resolved Hide resolved
@AlexVCaron
Copy link
Collaborator

@ThoumyreStanislas can you fix the last little comments when you have 2 minutes ? Then I can merge ⛵

@AlexVCaron AlexVCaron added this pull request to the merge queue Sep 3, 2024
Merged via the queue into scilus:main with commit ce18ebb Sep 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants