Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix atlas handling and transform file issues in bundle_seg #80

Merged
merged 10 commits into from
Jan 15, 2025

Conversation

gagnonanthony
Copy link
Contributor

@gagnonanthony gagnonanthony commented Dec 12, 2024

When we changed how to provide a local copy of the bundle_seg atlas, we did not modify the path where the subworkflow fetches the files.

We don't have test data to include in the test suite, but I did try it locally, and everything runs smoothly.

@gagnonanthony
Copy link
Contributor Author

We should discuss what to do with the transform files as output from the registration scripts. As shown here, we might need to access only one of the two transformation files from the output channel. I'm not sure this is the best way to do it, because

  1. It is not intuitive to extract (flatten, then back to list, then map).
  2. It won't work if the user select rigid transform, since only one transformation file will be outputted.

I think we should separate the output files in individual channels. From my experience, this also facilitates the pipeline/subworkflows creation process. What do you think @AlexVCaron, @ThoumyreStanislas, @arnaudbore, @Manonedde ?

@gagnonanthony gagnonanthony changed the title Fix external atlas use in bundle_seg Fix atlas handling and transform file issues in bundle_seg Dec 13, 2024
@AlexVCaron
Copy link
Collaborator

Go for it ! I do agree it will make things easier. We implemented it that way to facilitate chaining transforms and prevent errors, but it just makes things harder and obscure.

@gagnonanthony
Copy link
Contributor Author

I've updated the registration scripts @AlexVCaron. However, I struggle to update the snap of synthregistration (I do not have 20GB of RAM available...). Could you update them?

@AlexVCaron
Copy link
Collaborator

I've updated the registration scripts @AlexVCaron. However, I struggle to update the snap of synthregistration (I do not have 20GB of RAM available...). Could you update them?

I'm on that !

@AlexVCaron
Copy link
Collaborator

@rerun-checks

@AlexVCaron
Copy link
Collaborator

The tests pass ! But version files don't match for synthseg in the subworkflow ... so close, yet still not there yet 😅

@AlexVCaron
Copy link
Collaborator

AlexVCaron commented Jan 14, 2025

The tests pass ! But version files don't match for synthseg in the subworkflow ... so close, yet still not there yet 😅

FYI, I assume you know this already, you can fake the version file at the correct versions and use md5sum to get the encoded descriptor.

Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once version files are fixed, and the few comments I left here, this will be GTG ! 🚢

Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG on my end, once the tests pass 🤟🏻 Great job !

@AlexVCaron AlexVCaron added this pull request to the merge queue Jan 15, 2025
Merged via the queue into scilus:main with commit 31acac3 Jan 15, 2025
21 checks passed
@gagnonanthony gagnonanthony deleted the fix/atlasbundleseg branch January 16, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants