Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] tracking module #21

Merged
merged 3 commits into from
Oct 30, 2024
Merged

[ENH] tracking module #21

merged 3 commits into from
Oct 30, 2024

Conversation

arnaudbore
Copy link
Contributor

@arnaudbore arnaudbore commented Oct 24, 2024 •
edited by ThoumyreStanislas
Loading

#14

Type of improvement

Update Module tracking

If submitting a new module or fixing a bug, please use the appropriate template.

  • Documentation
  • Development tools (e.g. linter, formatter, etc.)
  • Development container
  • Global update (please specify)
  • Other (please specify)

Checklist before requesting a review

  • Ensure the syntax is correct (EditorConfig and Prettier must pass)
  • Run the test suites if your changes affect any module
  • Regenerate the Poetry lock file if you have updated the dependencies
  • Ensure the documentation is up-to-date

ThoumyreStanislas
ThoumyreStanislas approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@ThoumyreStanislas ThoumyreStanislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arnaudbore arnaudbore removed the request for review from AlexVCaron October 30, 2024 13:08
gagnonanthony
gagnonanthony approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG! 🍻

@arnaudbore arnaudbore added this pull request to the merge queue Oct 30, 2024
Merged via the queue into scilus:main with commit 30047fb Oct 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagnonanthony gagnonanthony gagnonanthony approved these changes

@ThoumyreStanislas ThoumyreStanislas ThoumyreStanislas approved these changes

@Manonedde Manonedde Awaiting requested review from Manonedde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnaudbore @gagnonanthony @ThoumyreStanislas