Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pyplot savefig() #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add pyplot savefig() #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion persim/visuals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ def plot_diagrams(
lifetime=False,
legend=True,
show=False,
ax=None
ax=None,
save=False,
figures_directory=None,
filename=None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need both save and filename? How about if filename is not None, then save to the filename

):
"""A helper function to plot persistence diagrams.

Expand Down Expand Up @@ -175,6 +178,9 @@ def plot_diagrams(
if show is True:
plt.show()

if save is True:
plt.savefig(figures_directory + filename)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change it to only accept one argument, filename please.



def bottleneck_matching(I1, I2, matchidx, D, labels=["dgm1", "dgm2"], ax=None):
""" Visualize bottleneck matching between two diagrams
Expand Down