Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New features #49

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

New features #49

wants to merge 18 commits into from

Commits on Nov 16, 2020

  1. feat: implement various checks for parameters

    @fayeab
    fayeab committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    994991f View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. feat: implement a function to compute confusion matrix and some metri… 

    …cs based on confusion matrix (precision, recall, ...)
    @fayeab
    fayeab committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    1dd5e29 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. feat: add function check_max_samples to utils/__init__.py

    @fayeab
    fayeab committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    8fc67a0 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. fix: function check_custom_func to utils/__init__.py takes now 1 para… 

    …meter instead of 4
    @fayeab
    fayeab committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    e4a323d View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2020

  1. feat: Add new filtering and duplication criteria 

          Check the parameters of SkopeRules
      Remove precision_min and recall_min parameters

Signed-off-by: fayeab <[email protected]>
    @fayeab
    fayeab committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    46f0d14 View commit details
    Browse the repository at this point in the history

  2. Fix: update the examples after some modifications of SkopeRules 

    Signed-off-by: fayeab <[email protected]>
    @fayeab
    fayeab committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    edab330 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2020

  1. Fix: update tests after some modifications of SkopeRules 

    Signed-off-by: fayeab <[email protected]>
    @fayeab
    fayeab committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    d1f48fe View commit details
    Browse the repository at this point in the history

  2. Fix: update example on plotting default credit 

    Signed-off-by: fayeab <[email protected]>
    @fayeab
    fayeab committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    3c0ed2b View commit details
    Browse the repository at this point in the history

  3. The file requirements.txt is modified because of the sklearn.datasets… 

    ….base and sklearn.utils.testing modules are deprecated in version 0.22 and will be removed in version 0.24

Signed-off-by: fayeab <[email protected]>
    @fayeab
    fayeab committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    38e7ce4 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. Revert "The file requirements.txt is modified because of the sklearn.… 

    …datasets.base and sklearn.utils.testing modules are deprecated in version 0.22 and will be removed in version 0.24"

This reverts commit 38e7ce4.
    @fayeab
    fayeab committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    ce01432 View commit details
    Browse the repository at this point in the history

  2. Revert "Fix: update example on plotting default credit" 

    This reverts commit 3c0ed2b.
    @fayeab
    fayeab committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    8bf086c View commit details
    Browse the repository at this point in the history

  3. Revert "Fix: update tests after some modifications of SkopeRules" 

    This reverts commit d1f48fe.
    @fayeab
    fayeab committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    cf07284 View commit details
    Browse the repository at this point in the history

  4. Fix: Update tests files after some modifications on SkopeRules class. 

    Signed-off-by: fayeab <[email protected]>
    @fayeab
    fayeab committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    98ab7a8 View commit details
    Browse the repository at this point in the history

  5. Fix: Update the example after some modifications on SkopeRules class. 

    Signed-off-by: fayeab <[email protected]>
    @fayeab
    fayeab committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    29c2572 View commit details
    Browse the repository at this point in the history

  6. Fix: Add some modifications because of sklearn.datasets.base will be … 

    …removed in version 0.24.

Signed-off-by: fayeab <[email protected]>
    @fayeab
    fayeab committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    b47f812 View commit details
    Browse the repository at this point in the history

  7. Update requirements because of the sklearn.datasets.base and sklearn.… 

    …utils.testing modules are deprecated in version 0.22 and will be removed in version 0.24

Signed-off-by: fayeab <[email protected]>
    @fayeab
    fayeab committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    d1ea9a4 View commit details
    Browse the repository at this point in the history

  8. Fix : Check estimator fails because sklearn version 0.24 checks sampl… 

    …e_weight. This parameter is not use in same way by skrules.

Signed-off-by: fayeab <[email protected]>
    @fayeab
    fayeab committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    2711132 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. Fix : SkopeRules, parameter 'filtering_criteria', type dict which is … 

    …not allowed by scikit-learn checks in version 0.24. All init parameters have to be immutable to make cloning possible.

Signed-off-by: fayeab <[email protected]>
    @fayeab
    fayeab committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    3ecef04 View commit details
    Browse the repository at this point in the history