Update who feature selection example #212
Conversation
agoscinski
changed the title
The plot has been updated with the revision of the ore paper * change kernel ridge to linear regression * add correlation plot that shows similarity between the selector methods
agoscinski
force-pushed
the
update-who-example
branch
from
463d1f1
to
5829064
Compare
|
this added plot at the end of this example https://scikit-matter--212.org.readthedocs.build/en/212/examples/selection/FeatureSelection-WHODataset.html#sphx-glr-examples-selection-featureselection-whodataset-py is the main change |
|
Observation for both the notebook and the paper: I would only show the lower-left corner, and also not show the diagonal. Those are redundant. |
|
Updated it in the paper but I would keep this redundancy for the example. Redundancy can help with understanding. Also making such a plot with matplotlib would make the code more complicated which also reduces readability. |
OK I see the point of keeping the code clean in the example (although in many examples we have pretty sophisticated matplotlib layouts). Good with me then |
The plot has been updated with the revision of the ore paper. See corresponding plot in the ore repo https://github.com/victorprincipe/skmatter-ore/blob/main/paper/WhoDataset-Selection.ipynb
change kernel ridge to linear regression
add correlation plot that shows similarity between the selector methods
📚 Documentation preview 📚: https://scikit-matter--212.org.readthedocs.build/en/212/