Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1292.
I fixed the
closed
property ofFSSpecSource
so that it doesn't always returnFalse
. I asked Luis about this, and here's my current understanding. This property was added so that it didn't just use the inherited property fromSource
since it wouldn't work for custom executors.uproot5/src/uproot/source/chunk.py
Lines 168 to 177 in a331467
However, we can simply use the
closed
property of_file
as shown in the changes below. I'm tagging @lobis to see if he has any concerns about this.I also changed the
chunk(s)
methods to perform a closure check before reading. So now the example in #1292 fails.