-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add prettier to pre-commit hook configuration #2538
base: main
Are you sure you want to change the base?
Conversation
pre-commit.ci autofix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @tkoyama010. I'll talk with @kratsg about this, but we've avoided enabling prettier
in the past because of it causing regular breakage (example: prettier/prettier#15742) without adding much benefit.
Thanks for comment. Closing this :) |
@tkoyama010 I'm reopening this PR for now so that @kratsg and I can discuss it. I don't want to close your contribution prematurely! :) |
Sorry. It was just before I got on the train and I was in a rush. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2538 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 69 69
Lines 4543 4543
Branches 804 804
=======================================
Hits 4462 4462
Misses 48 48
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Add prettier to pre-commit hook configuration.
ref PC180 in Scientific Python Library Development Guide.
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: