refactor: simplify attrs & fix its pickability (for e.g. dask.distributed) #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianna
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
@pfackeldey - Thanks, it looks great! Indeed, the code is cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
.attrsproperly pickable again by getting rid of the weak reference (without loosing the intended behavior introduced in #3344).Without this PR we'll break any usage with dask.distributed as it needs to pickle all objects (including
.attrs) for scheduling.Thus, we should get this PR in before a new awkward-array release.
(and also I think it's much cleaner now :-) )