fix: placeholder array repr with extra info #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianna
reviewed
Jan 23, 2025
There was a problem hiding this comment.
@pfackeldey - I'm a bit confused about TypeTracerArray. Do we support it?
ianna
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the repr of PlaceholderArrays for good by moving the
array_strinto the array module (nplike).Currently the repr could be printed if no extra information is present, however, when a
parameterexists (which is typically the case for e.g.coffea.NanoEventsthat includes the__doc__of a TBranch as a parameter) the repr was broken.This should also be a more cleaner approach as it avoids runtime type dependent if conditions in certain parts of the codebase.