refactor: split "meta" into Meta
#2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
force-pushed
the
agoose77/refactor-meta
branch
4 times, most recently
from
1578317 to
4dacbf4
Compare
|
I don't think we can / should group |
refactor: move more metadata handling into meta refactor: more typing remove more to meta
agoose77
force-pushed
the
agoose77/refactor-meta
branch
from
d0a0026 to
2fa362a
Compare
jpivarski
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Yes, we have been talking about this for a long time.
Sure, let's go ahead with this, but only if it isn't disruptive. From a user's or downstream developer's perspective, the Form and Content classes should appear to be as they have been (i.e. a pure refactor).
And yes, Types don't fit into this scheme.
agoose77
force-pushed
the
agoose77/refactor-meta
branch
from
06e56b3 to
5cbcb71
Compare
Codecov Report
Additional details and impacted files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jpivarski and I have discussed this on-and-off for over a year now.
Presently,
ak.contents.Contentsubclasses re-use code fromak.forms.Formsubclasses using explicit descriptor lookups. As such,ak.forms.Formserves as the implementation for many metadata methods. As we look to grow the set of metadata-only methods, it would be nice to formalise this hierarchy. Benefits include:Content.parameterinvolves an additional attribute lookup and function call)As it now seems possible that we'll want an
enforce_formfunction, I would like for the ability to implement the_mergeable_nextprotocol at the "meta" level, and doing this properly feels more readable (and easier to reason about) to me; we're not fighting the type system by implementing this via inheritance.