fix: handle reordered contents in ak.almost_equal
#2424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
changed the title
ak.almost_equal
jpivarski
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
I see that this was pulled out of #2365 (comment)
Approved!
We can skip the codecov that didn't run. Maybe we should make it a non-required test, considering how often it fails to start.
|
I removed codecov as a required test. (It was a weak requirement anyway; the test coverage would have to drop way down for it to fail.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ak.almost_equalmade some poor assumptions about content orderings, which this PR fixes. Now, unions are considered equal against unions with different content orders (as long as the tags align equally). Records are compared by field for non-tuples, addressing the same problem with records.