Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added droplet example #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added droplet example #59

wants to merge 2 commits into from

Conversation

jrmlhermitte
Copy link
Contributor

added ipython notebook demonstrating use of droplet algorithm

@ericdill
Copy link
Member

Very cool. Thanks for this notebook!

Might I suggest a name change on the functions in droplet? In this import

from skbeam.core.accumulators.droplet import dropletfind, dropletanal

we have the word droplet twice. We can probably do something like this instead:

from skbeam.core.accumulators import droplet

and then do

droplet.find(...)
droplet.analyze(...)

this has the advantage of also getting rid of the, uh (this is awkward) unintentionally suggestive dropletanal. Abbreviating analysis or analyze is always difficult for that reason.

All of this is of course if we decide to keep the droplet algorithm, so let's let that discussion run its course before any changes are made here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants