Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore login #63

Merged
merged 6 commits into from
Feb 28, 2024
Merged

restore login #63

merged 6 commits into from
Feb 28, 2024

Conversation

alishaevn
Copy link
Contributor

@alishaevn alishaevn commented Feb 28, 2024

Story

bring in the following changes:

Video

Zight.Recording.2024-02-28.at.04.27.34.PM.mp4

- formatting
- add step to running the wcl in dev mode
the `signIn` function from "next-auth/react" uses `fetcher` and returns
a 404 error response. throwing that error causes an `OAUTH_CALLBACK_HANDLER_ERROR`,
which prevents users from signing in. `signIn` doesn't pass a url to `fetcher`.
the check below ensures that other errors still get thrown

- ref: scientist-softserv/webstore#321
Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
phenovista ✅ Ready (Inspect) Visit Preview Feb 28, 2024 10:49pm

@alishaevn alishaevn merged commit 06c870b into main Feb 28, 2024
6 of 7 checks passed
@alishaevn alishaevn deleted the restore-login branch February 28, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant