Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two CI regressions (new beta toolchain lint and unmaintained crate advisory) #438

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

ammernico
Copy link
Member

@ammernico ammernico commented Nov 11, 2024

Ignore an unmaintained crate deny check for now/Add a lifetime to an return type for the beta check

This isn't a security issue yet, the `indicatif` crate should get rid
of it eventually, and this isn't really actionable for us so let's
ignore that informative advisory so that CI remains green (it's an
optional CI check but the failure could mask real vulnerabilities and
does also mark the CI run with a red cross on the GitHub UI).

Thank you <[email protected]> for the nice copypasta commit
message from the last deny unmaintained advisory.

Signed-off-by: Nico Steinle <[email protected]>
The rust beta version fails to compile without those.

Signed-off-by: Nico Steinle <[email protected]>
@ammernico ammernico changed the title Ignore an unmaintained crate deny check for now/Add a lifetime to an return type for the beta check Make the ci/cd happy Nov 11, 2024
Copy link
Member

@primeos-work primeos-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

The rust beta version fails to compile without those.

Nit: That's only because we run CI with -D warnings - by default, the elided_named_lifetimes lint only emits warnings.

(Nit2: I'll also edit the PR title as we don't have CD (yet). Nit3: Seems like I made the title a bit too long though...)

@primeos-work primeos-work changed the title Make the ci/cd happy Fix two CI regressions (new beta toolchain lint and unmaintained crate advisory) Nov 12, 2024
@primeos-work primeos-work added this pull request to the merge queue Nov 12, 2024
Merged via the queue into science-computing:master with commit 81c9261 Nov 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants