Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve failed evaluation detection, reporting #123

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Improve failed evaluation detection, reporting #123

merged 1 commit into from
Sep 24, 2024

Commits on Sep 22, 2024

  1. Improve failed evaluation detection, reporting 

    Issue: When we ask Wolfram to do something impossible, it typically returns the input form or $Failed, so it is hard to see what was wrong. However, when evaluated in a notebook, it does print an explanation. This is however ignored by the recommended `.waitForAnswer`.

Fix: Follow the docs and add a packet listener, which captures the messages we care about in these cases (text, message) between we start eval and read the result. To make this easier, move the impl. of evaluation into a new protocol method `evaluate!` + add extracting captured messages from the listener + throw an error if the result seems to indicate a problem.

Bonus: Upgrade Clojure to stable.
    @holyjak
    holyjak committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    7253ec9 View commit details
    Browse the repository at this point in the history