Fix #111: wl/start etc return value #121
Conversation
Issue: An inexperienced user may not know what the return value of nil means. Fix: Be explicit and return a map with `:status :ok` and perhaps additional info. E.g. wolfram version seems useful.
This comment was marked as resolved.
This comment was marked as resolved.
Throw an error if Get fails, e.g. b/c the package does not exist. Return the alias symbol on succesful load.
holyjak
force-pushed
the
feat-111-start-return-val
branch
from
1a5a7f4
to
96de154
Compare
|
Works well at my end. I had to do the tests manually though as there seems to be something wrong with the namespace detection (probably an Emacs setup bug). How do you feel about adding an exclamation mark to the end of start,restart etc. though? I know that last time it was deemed unnecessary, but somehow I miss the consistency with side-affecting operations. |
|
No strong feelings here. If you really want it, we can change it. Will need to update docs... |
|
Let's do it. I know it seems like an awkward use of time, but it would help my mild OCD :). |
|
I can do it later or tomorrow morning. |
|
just remember to run tests and build site on this branch, before merging... |
|
I do not like |
Yep, I thought it was more controversial and I hesitated, but made it a separate commit to make it easy to remove. I don't really see the problem with it, but it's true that it's not always side-affecting. Ironically, I would like to find a shorter way to call it and I was thinking that using wl/! as an alternative to eval would be more ergonomic when playing with different expressions. |
light-matters
force-pushed
the
feat-111-start-return-val
branch
from
1d5ecb1
to
d7ad8bf
Compare
|
Think that's it reset. |
|
tests and website seem to run, but I discovered a bug (in the public site) that I'll post an issue for. |
Issue: An inexperienced user may not know what the return value of nil means.
Fix: Be explicit and return a map with
:status :okand perhaps additional info. E.g. wolfram version seems useful.