Increase range for single id in Tuple (from 16 to 32bits) #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 16, 2017 22:32
Now single id in Tuple can be in higher range (32 bits per id) thanks to ArrayBuffer first we store each id in ArrayBuffer/DataView(8 bytes = js number) as uint32 at 0 byte and 4 byte second step is to get key by getting js number (8 bytes from whole buffer) thats it! :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now single id in Tuple can be in higher range (32 bits per id) thanks to ArrayBuffer
first we store each id in ArrayBuffer/DataView(8 bytes = js number) as uint32 at 0 byte and 4 byte
second step is to get key by getting js number (8 bytes from whole buffer)
thats it! :D
the key thing, it is a bit slower when you do this 100 000 times at once:
https://jsfiddle.net/9zsrf0rx/
but if "tries" is set to 1000 its almost the same and sometimes a bit faster.
Maybe we can colaborate about this a bit to make it even better.