Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: avoid error while emitting 'EndShapeContact' events. #408

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dtysky
Copy link

@dtysky dtysky commented Nov 28, 2018

Hi.

I used events 'beginContact', 'endContact', 'beginShapeContact' and 'endShapeContact' and found that if I remove body or shapes in the callback of 'beginContact' like this:

world.addEventListener('beginContact', args => {
      world.remove(args.bodyB);
});

Then an error will be thrown:

cannon.js:14503 Uncaught TypeError: Cannot read property 'body' of undefined
at World.emitContactEvents (cannon.js:14503)
at World.internalStep (cannon.js:14312)
at World.step (cannon.js:14031)

So I add this condition to avoid it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant