-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nucleic Acid builder and general improvements #354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the point that there is a lot to be done here with regard to refactoring and improving readability (looking at you editor.py
). However, for now I think this is everything we need to add this feature to open-source. We should file a ticket on the incentive side of things to get this cleaned up and then merge those changes in later on.
I also agree, first sync with open-source, then refactor. But before jumping to refactoring: Are there any tests? There are none in this pull request. |
Removed the incentive requirement. All previous tests (which included 'fnab') for this module were brought over during the pymol-testing migration. |
Addresses #102 #351
Migrating support from Incentive for the following:
fnab
command to build nucleic acid chains by sequence (Jarrett Johnson @JarrettSJohnson)Co-authored-by: Jarrett Johnson [email protected]
Co-authored-by: Thomas Stewart [email protected]
Co-authored-by: Thomas Holder [email protected]