Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for V2 #692

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Add docs for V2 #692

merged 1 commit into from
Aug 3, 2023

Conversation

pradeepnschrodinger
Copy link
Collaborator

Description

This adds documentations for the v2 release.
I added a separate section for Plugins and Public API.
Currently the docs for Public API methods/state are written manually, but in the future we want this to be auto-generated.

Screenshots:

image image image image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@AmanGupta2708
Copy link
Collaborator

How will user switch between v1 and v2 docs ?

@pradeepnschrodinger
Copy link
Collaborator Author

How will user switch between v1 and v2 docs ?

They can't. We never had this feature implemented. :(
With that said, upgrading from v1 to v2 should be non-breaking for clients.

@@ -31,7 +31,7 @@ var FILES_TO_READ = [
},
{
path: path.join(PROJECT_ROOT, 'src/FixedDataTableCellDefault.js'),
name: 'Cell',
name: 'DataCell',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the component renamed or it was mistyped here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cell is the older and now deprecated component.
DataCell is the newer replacement. (#687 )

};

class DocsPage extends React.Component {
render() {
const HTML = DOCS_MARKDOWN_FILES[this.props.page.location];

let pageClassname = 'pageBody';
if (this.props.page.pageClassname) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is page always defined here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be, but I'll smoke test it.
It's hard to immediately know without prop types defined...

@karry08
Copy link
Collaborator

karry08 commented Jul 31, 2023

How does the auto-generate thing works?

@karry08
Copy link
Collaborator

karry08 commented Jul 31, 2023

LGTM

@pradeepnschrodinger
Copy link
Collaborator Author

How does the auto-generate thing works?

@karry08, check out buildAPIDocs.sh. It uses react-docgen internally.

@pradeepnschrodinger pradeepnschrodinger merged commit 5ea33d1 into v2.0-beta Aug 3, 2023
6 checks passed
@pradeepnschrodinger pradeepnschrodinger deleted the v2.0-beta-docs branch August 3, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation v2.0-beta Tickets targeting the v2.0-beta branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants