Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make access strategies aware of the context #962

Merged
merged 3 commits into from
Jun 12, 2018

Conversation

goetas
Copy link
Collaborator

@goetas goetas commented Jun 7, 2018

Q A
Bug fix? no
New feature? yes
Doc updated no
BC breaks? not yet
Deprecations? no
Tests pass? yes, but need new tests
Fixed tickets -
License MIT

@goetas goetas added this to the 2.0.0 milestone Jun 7, 2018
@goetas
Copy link
Collaborator Author

goetas commented Jun 7, 2018

Has the drawback that making access strategies compiled in the future will be more difficult... but I had many cases where I needed some extra info when using custom access (as expression language as example)

@goetas
Copy link
Collaborator Author

goetas commented Jun 7, 2018

Another way would be introducing and AccessorStrategyFactory that is invoked in the serialization step (instead of using the current single object instance) to produce the AccessorStrategyInterface object

@goetas
Copy link
Collaborator Author

goetas commented Jun 12, 2018

as explored in #964 #903 #933 , it is not easy to have compiled graph navigators, exclusion strategies or access strategies... and even more weird, performance improvements are not really visible...

Becase of that, I think can be a fine.

@goetas goetas removed the RFC label Jun 12, 2018
@goetas goetas merged commit 3d20a4d into master Jun 12, 2018
@goetas goetas deleted the context-aware-access-strategy branch June 12, 2018 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant