Generated hydrators #933
Generated hydrators #933
Conversation
|
@Majkl578 What do you think? |
|
I have checked the approach used internally by ocraminus, in reality used |
Yes, that is true. But he does that at once for whole object, not per-property. Calling closure per property (imagine 30 properties per object) will be slower than calling it once for all :) |
|
the version in this PR is 10% slower that the current master... 😕 .... still to figure out why. |
|
As noted on Slack:
|
| $this->gen[$class] = new $hydratorClass(); | ||
| } | ||
|
|
||
| return $this->gen[$class]->extract($object); |
There was a problem hiding this comment.
@Majkl578 generators are generated and cached, so is "production" ready after the warmup.
There was a problem hiding this comment.
The code inside the "if" is never executed during the benchmark, so should not make it slower
tried to implement #904, but for now looks slower...must be doing something wrong